fix(issue#4354): unknown at-rule expression commas#4387
Closed
puckowski wants to merge 1 commit intoless:masterfrom
Closed
fix(issue#4354): unknown at-rule expression commas#4387puckowski wants to merge 1 commit intoless:masterfrom
puckowski wants to merge 1 commit intoless:masterfrom
Conversation
* Fix issue less#4354 unknown at-rule expressions should not have commas in a keyword list. * Add some additional layer at-rule tests.
3 tasks
Contributor
Author
|
@matthew-dean I know we have a major test refactor pending but I hope you can review the general idea of this PR in your spare time since this bug is impactful. |
3 tasks
Contributor
Author
|
Closing in favor of #4389 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Fix issue #4354 unknown at-rule expressions should not have commas in keyword list.
Why:
Current behavior (4.4.0+):
Expected behavior:
There have been downstream issues, see: web-infra-dev/rsbuild#5688
Checklist:
Should be a less hacky solution than #4366
Seems some logic was not needed as tests passed without some problematic code.
I added some additional layer at-rule tests since the regression was caused by code ntroduced to support layer at-rules.